perf(job): set processedBy using hmset (#2592) (python)

taskforcesh · Jun 4, 2024 · 238680b · 238680b
1 parent c19c839
commit 238680b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/commands/includes/addDelayMarkerIfNeeded.lua b/src/commands/includes/addDelayMarkerIfNeeded.lua
@@ -6,10 +6,10 @@
 --- @include "getNextDelayedTimestamp"
 
 local function addDelayMarkerIfNeeded(markerKey, delayedKey)
-    local nextTimestamp = getNextDelayedTimestamp(delayedKey)
-    if nextTimestamp ~= nil then
-        -- Replace the score of the marker with the newest known
-        -- next timestamp.
-        rcall("ZADD", markerKey, nextTimestamp, "1")
-    end
+  local nextTimestamp = getNextDelayedTimestamp(delayedKey)
+  if nextTimestamp ~= nil then
+    -- Replace the score of the marker with the newest known
+    -- next timestamp.
+    rcall("ZADD", markerKey, nextTimestamp, "1")
+  end
 end
diff --git a/src/commands/includes/prepareJobForProcessing.lua b/src/commands/includes/prepareJobForProcessing.lua
@@ -29,13 +29,16 @@ local function prepareJobForProcessing(keyPrefix, rateLimiterKey, eventStreamKey
     rcall("SET", lockKey, opts['token'], "PX", opts['lockDuration'])
   end
 
+  local optionalValues = {}
+
   if opts['name'] then
     -- Set "processedBy" field to the worker name
-    rcall("HSET", jobKey, "pb", opts['name'])
+    table.insert(optionalValues, "pb")
+    table.insert(optionalValues, opts['name'])
   end
 
   rcall("XADD", eventStreamKey, "*", "event", "active", "jobId", jobId, "prev", "waiting")
-  rcall("HSET", jobKey, "processedOn", processedOn)
+  rcall("HMSET", jobKey, "processedOn", processedOn, unpack(optionalValues))
   rcall("HINCRBY", jobKey, "ats", 1)
 
   return {rcall("HGETALL", jobKey), jobId, 0, 0} -- get job data