Bug 1468606 - add servicesManifest method #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a given taskcluster deployment
djmitche
approved these changes
Sep 6, 2018
| .npm | ||
|
|
||
| # npm package lock file | ||
| package-lock.json |
There was a problem hiding this comment.
This doesn't hurt anything, but FYI we now use yarn instead of npm to manage packages.
|
Looks like gometalinter needs a fix-up, but once that's fixed, good to land. |
I raised alecthomas/gometalinter#532 for this, thinking it was an upstream issue, but then discovered we have a |
|
Thanks guys! |
|
v10.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bug 1468606 for more context.
I've added a new method that returns the
manifest.jsonfile for a given taskcluster root url.At the same time I added some green ticks to the go tests, since I like the ones that
npm testproduces. 😉Thanks!