This repository has been archived by the owner on Jan 5, 2019. It is now read-only.
Adding a api.all.<status>.count and measure #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,6 +38,8 @@ export function expressMiddleware (monitor, name) { | |||
| monitor.measure(k, d[0] * 1000 + d[1] / 1000000); | |||
| monitor.count(k); | |||
| } | |||
| monitor.measure(['all', stat], d[0] * 1000 + d[1] / 1000000); | |||
There was a problem hiding this comment.
I think you want to either move this inside the loop and end up with
taskcluster-queue.api.all.client-error.5m.count and taskcluster-queue.api.all.all.5m.count or replace stat in these new lines with success and only end up with taskcluster-queue.api.all.client-error.5m.count.
I might be misunderstanding though.
There was a problem hiding this comment.
Ah, that might be right...
Actually, I'm little suspicious as to the utility of all these alls.. some of them sure...
But given that 99% is success, then we might not need both all and success. As the percentiles will be the same...
There was a problem hiding this comment.
Ah, now I see the bug, thanks...
r+I'll merge this now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't run tests... Just quickly hacked it online, but I think this is what I meant...