Skip to content
This repository has been archived by the owner on Feb 20, 2020. It is now read-only.

Bug 1564819 - support docker engine on macOS #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petemoore
Copy link
Member

See bug 1564819 for context. Thanks!

@petemoore petemoore requested a review from milescrabill July 10, 2019 09:43
@petemoore petemoore self-assigned this Jul 10, 2019
@coveralls
Copy link

coveralls commented Jul 10, 2019

Coverage Status

Coverage decreased (-0.04%) to 76.715% when pulling 371f24d on bug1564819 into 62d8040 on master.

@petemoore petemoore force-pushed the bug1564819 branch 2 times, most recently from 2322297 to cdc89ec Compare July 10, 2019 19:01
Copy link
Contributor

@milescrabill milescrabill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass

.taskcluster.yml Outdated
################ macOS amd64 Docker Build ################
##########################################################

- provisionerId: pmoore-manual
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this only work for your iMac?

Copy link
Member Author

@petemoore petemoore Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, anything I manully provisioner I've been giving "provisionerId": "pmoore-manual" - so this covers a few different worker types, that themselves cover a few different workers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for that link :)

@petemoore petemoore force-pushed the bug1564819 branch 2 times, most recently from f8749dc to 1b7d27b Compare July 19, 2019 22:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants