Merge pull request #97 from taskcluster/channel-cleanup

Close livelog channels when finished with them
taskcluster · Jun 6, 2018 · 8cece2c · 8cece2c
2 parents 665d793 + af07c42
commit 8cece2c
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/livelog/livelog.go b/livelog/livelog.go
@@ -75,6 +75,7 @@ func New(liveLogExecutable, sslCert, sslKey string, putPort, getPort uint16) (*L
 	}
 	putResult := make(chan CommandResult)
 	go func() {
+		defer close(putResult)
 		var b bytes.Buffer
 		l.command.Stdout = &b
 		l.command.Stderr = &b
@@ -97,6 +98,7 @@ func New(liveLogExecutable, sslCert, sslKey string, putPort, getPort uint16) (*L
 
 	inputStreamConnectionResult := make(chan error)
 	go func() {
+		defer close(inputStreamConnectionResult)
 		err := l.connectInputStream()
 		inputStreamConnectionResult <- err
 	}()