fix docker build

tarunzoniqx · Dec 2, 2023 · da2d0be · da2d0be
1 parent 9c4c325
commit da2d0be
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/.github/workflows/api-image.yml b/.github/workflows/api-image.yml
@@ -29,12 +29,6 @@ jobs:
           rm -rf api
           ls -lah
 
-      - name: Log in to Docker Hub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKER_USERNAME }}
-          password: ${{ secrets.DOCKER_PASSWORD }}
-
       - name: Extract metadata (tags, labels) for Docker
         id: meta
         uses: docker/metadata-action@v5
@@ -49,6 +43,8 @@ jobs:
       - name: Build and push Docker image
         uses: docker/login-action@v3
         with:
+          username: ${{ secrets.DOCKER_USERNAME }}
+          password: ${{ secrets.DOCKER_PASSWORD }}
           context: .
           push: true
           tags: ${{ steps.meta.outputs.tags }}

diff --git a/.github/workflows/ui-image.yml b/.github/workflows/ui-image.yml
@@ -29,12 +29,6 @@ jobs:
           rm -rf ui
           ls -lah
 
-      - name: Log in to Docker Hub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKER_USERNAME }}
-          password: ${{ secrets.DOCKER_PASSWORD }}
-
       - name: Extract metadata (tags, labels) for Docker
         id: meta
         uses: docker/metadata-action@v5
@@ -49,6 +43,8 @@ jobs:
       - name: Build and push Docker image
         uses: docker/login-action@v3
         with:
+          username: ${{ secrets.DOCKER_USERNAME }}
+          password: ${{ secrets.DOCKER_PASSWORD }}
           context: .
           push: true
           tags: ${{ steps.meta.outputs.tags }}