Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade support for laravel 10 and update README.md #6

Merged
merged 2 commits into from
Apr 28, 2023
Merged

upgrade support for laravel 10 and update README.md #6

merged 2 commits into from
Apr 28, 2023

Conversation

aleprosli
Copy link
Contributor

@aleprosli aleprosli commented Apr 28, 2023 •
edited
Loading

  • illuminate/support updated. This will help the package can be supported up to laravel 10.

The README file has been revised

  • updated createBill section, $bill_object assigned from request.
  • to use the $category_code instead of $code in both getCategory and createBill sections. This will make it easier for users to understand where the $code variable comes from, and reduce any potential confusion.

@samtarmizi

samtarmizi
samtarmizi approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@samtarmizi samtarmizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samtarmizi samtarmizi merged commit ef84fe3 into tarsofttech:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtarmizi samtarmizi samtarmizi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleprosli @samtarmizi