Remove Hardcoding from java

tarsbirsingh · May 14, 2018 · 47c6ba1 · 47c6ba1
1 parent 3c6bb80
commit 47c6ba1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/app/src/main/java/com/example/hp/quiz/MainActivity.java b/app/src/main/java/com/example/hp/quiz/MainActivity.java
@@ -126,7 +126,7 @@ public void onClick(View v) {
                    score+=1;
                }
 
-                   String finalScore = "Hi " +name+ " you have Scored " + score+"  out of 10";
+                   String finalScore = getString(R.string.hi) +name+ getString(R.string.youHaveScored)+score+ getString(R.string.ten);
                    Toast.makeText(getApplicationContext(),finalScore,Toast.LENGTH_LONG).show();
 
 

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -2,6 +2,9 @@
     <string name="app_name">Quiz</string>
     <string name="qName">Android Quiz</string>
     <string name="Name"> Enter Your Name</string>
+    <string name="hi"> Hi \u0020 </string>
+    <string name="ten"> \u0020 out of 10  </string>
+    <string name="youHaveScored"> \u0020 you have Scored \u0020 </string>
     <!--q1-->
     <string name="Q1">Q1. What method you should override to use Android menu system ?</string>
     <string name="Q1_Op1">onCreateOptionsMenu()</string>