chore: remove unused BUG_REPORT_CHANNEL_ID and TICKET_CHANNEL_ID env vars - #29
Merged
Conversation
…vars Neither variable was read anywhere in the codebase — they only existed in the required-env list, forcing operators to configure values that were never used. Drops them from env validation, tests, .env.example, and README.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR removes BUG_REPORT_CHANNEL_ID and TICKET_CHANNEL_ID from required environment variables, replacing them with WELCOME_CHANNEL_ID in the config module, .env.example, README, and test setup. README also documents additional role-related variables. ChangesEnvironment variable update
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This comment was marked as resolved.
This comment was marked as resolved.
Add a Role IDs bullet covering PANEL_ADMIN_ROLE_ID and AUTO_ROLE_ID_1-4 (required at boot by src/config/env.js) plus optional ALLOWED_COMMAND_ROLE_IDS. Closes a docs gap surfaced during the PR #29 production-readiness review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
Maintainability sweep finding:
BUG_REPORT_CHANNEL_IDandTICKET_CHANNEL_IDwere listed as required environment variables but were never read anywhere in the codebase. Operators were forced to configure values that did nothing, and startup would fail without them.Changes
src/config/env.js— removed both vars fromrequiredEnvVarstest/env.test.js— removed both from theensureEnvVarshappy-path test.env.example— removed both example entriesREADME.md— removed both from the env config docsVerification
npm test→ 4/4 passrgconfirms zero remaining references to either variable (excludingnode_modules)depcheckconfirms no unused dependencies introducedRisk
Low — behavior-preserving deletion of dead configuration only. No runtime code path referenced these variables. Existing deployments with the vars set are unaffected (extra env vars are simply ignored).
CodeAnt-AI Description
Stop requiring unused Discord channel settings
What Changed
BUG_REPORT_CHANNEL_IDandTICKET_CHANNEL_IDfrom the required startup settings, so the app no longer fails if they are missingImpact
✅ Fewer startup failures✅ Shorter setup for new installs✅ Clearer environment configuration💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.