Repository navigation
fix(server): pairing links no longer fail on node versions that cannot bind booleans - #263
Merged
Merged
Conversation
…t bind booleans The consume query bound a raw boolean, which node:sqlite rejects before Node 24.21.0, so every stored pairing token failed with HTTP 500 on the Nix runtime (nodejs 24.20). Backport of pingdotgg/t3code#16730 (fixes pingdotgg/t3code#16797).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Redeeming any stored pairing token (the startup pairing URL,
t3 pair, links from Connections settings) returns HTTP 500 (access_token_issuance_failed). The consume query inAuthPairingLinks.ts, changed by upstream #10298, binds a raw JS boolean, andnode:sqliterejects boolean parameters before Node 24.21.0. The fork's Nix runtime ships nodejs 24.20, so Nix-built servers cannot pair. Found while smoke testing the 2026-10-08 actualization.Change
Bind
1/0instead oftrue/false. Backport of pingdotgg/t3code#16730, which is still open upstream; fixes pingdotgg/t3code#16797 for the fork.Scope and approval
Single-line fix to an obvious upstream bug, identical to the upstream fix PR.
Verification
PairingGrantStore.test.ts+EnvironmentAuth.test.tsunder Node 24.20.0 (the Nix runtime's node): 6 failures withProvided value cannot be bound to SQLite parameter 5before, 28/28 pass after.nix build .#t3code-headless+t3 serve+t3cli auth pair.Claude Opus 5.5 via Claude Code in T3 Code.