Skip to content

Use long names for curl options and document their usage #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2020
Merged

Use long names for curl options and document their usage #243

merged 2 commits into from
Jun 26, 2020

Conversation

gpetiot
Copy link
Contributor

@gpetiot gpetiot commented Jun 25, 2020

as discussed in #177

From reading the curl documentation it's not obvious to me whether the --config option is necessary, does someone has more experience with it?
I don't think we need to add a changelog entry for this PR.

@gpetiot gpetiot requested review from NathanReb and pitag-ha June 25, 2020 16:22
Copy link
Member

@pitag-ha pitag-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've really liked this approach of improving internal understanding of the code by choosing OCaml-style writing and .mli-documenting instead of strings. Thanks!

@gpetiot gpetiot merged commit ec671e9 into tarides:master Jun 26, 2020
@gpetiot gpetiot deleted the curl-options branch June 26, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants