feat: allow windows to build with either visual studio 2022 or visual studio 2019 #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leet4tari
approved these changes
Nov 13, 2024
Contributor
leet4tari
left a comment
leet4tari
left a comment
There was a problem hiding this comment.
basic testing, works in CI build test matrix.
SWvheerden
approved these changes
Nov 13, 2024
Contributor
|
Tested on my windows machine with VS 2022 and it compiles fine 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The build will now use either
Visual Studio 17 2022orVisual Studio 16 2019, whichever environment is sourced. It is still up to the user to start a Visual Studio Developer command prompt and build from there.Motivation and Context
The build was failing with newly created build environments, as Visual Studio 16 2019 is only available to prior Visual Studio subscribers.
XMRig now supports
Visual Studio 17 2022as well.How Has This Been Tested?
It was built using both platforms.
What process can a PR reviewer use to test or verify this change?
Code review
Run the build
Breaking Changes