Skip to content

Conversation

@poszu
Copy link
Contributor

@poszu poszu commented May 30, 2023

Closes #54

Motivation

I looked over the tests in the RandomX C library and I found discrepancies in dataset initialization. The docs say:

In order to use the Dataset, all items from 0 to (randomx_dataset_item_count() - 1) must be initialized.

In effect, all hashes calculated in fast mode (FLAG_FULL_MEM) are invalid.

Changes:

@poszu poszu changed the title Fix dataset initialization fix: dataset initialization May 31, 2023
@CjS77 CjS77 requested a review from SWvheerden June 6, 2023 16:42
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goodf, just remove that dead code

@poszu
Copy link
Contributor Author

poszu commented Aug 2, 2023

@SWvheerden is there anything else I need to do?

@SWvheerden
Copy link
Collaborator

Thanks for the ping, this slipped under the radar.

@SWvheerden
Copy link
Collaborator

Is it possible to rebase the commits and sign them with gpg?
I see you singed commit d98bd3a, but not the rest?

The project is blocking me from merging unless all commits are singed.

@poszu poszu force-pushed the test-light-vs-fast-vm branch from 43bb0e0 to aa99ae3 Compare August 3, 2023 12:22
@poszu
Copy link
Contributor Author

poszu commented Aug 3, 2023

@SWvheerden

Is it possible to rebase the commits and sign them with gpg? I see you singed commit d98bd3a, but not the rest?

The project is blocking me from merging unless all commits are singed.

Done

@poszu
Copy link
Contributor Author

poszu commented Aug 8, 2023

@SWvheerden ping

@SWvheerden SWvheerden merged commit 55739d1 into tari-project:development Aug 8, 2023
@poszu poszu deleted the test-light-vs-fast-vm branch August 8, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hashing in light and fast mode give different results

3 participants