-
Notifications
You must be signed in to change notification settings - Fork 33
fix: dataset initialization #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dataset initialization #55
Conversation
hansieodendaal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
SWvheerden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks goodf, just remove that dead code
|
@SWvheerden is there anything else I need to do? |
|
Thanks for the ping, this slipped under the radar. |
|
Is it possible to rebase the commits and sign them with gpg? The project is blocking me from merging unless all commits are singed. |
Quoting RandomX 'randomx_init_dataset' docs: In order to use the Dataset, all items from 0 to (randomx_dataset_item_count() - 1) must be initialized.
43bb0e0 to
aa99ae3
Compare
Done |
|
@SWvheerden ping |
Closes #54
Motivation
I looked over the tests in the RandomX C library and I found discrepancies in dataset initialization. The docs say:
In effect, all hashes calculated in fast mode (
FLAG_FULL_MEM) are invalid.Changes:
RandomXDatasetinitialization so that allrandomx_dataset_item_count()items are initialized;RandomXDataset::count()into an associated function as it is only a wrapper overrandomx_dataset_item_count()and it doesn't require an instance in order to be called.