f - check for invalid sorting strategies

target · Apr 27, 2022 · b7eb80a · b7eb80a
1 parent 975637b
commit b7eb80a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/reaper/options.go b/reaper/options.go
@@ -1,6 +1,7 @@
 package main
 
 import (
+	"errors"
 	"fmt"
 	v1 "k8s.io/api/core/v1"
 	"os"
@@ -166,7 +167,14 @@ func maxPods() (int, error) {
 }
 
 func podSortingStrategy() (func([]v1.Pod), error) {
-	return func(pods []v1.Pod) {}, nil
+	sortingStrategy, present := os.LookupEnv(envPodSortingStrategy)
+	if !present {
+		return func(pods []v1.Pod) {}, nil
+	}
+	switch sortingStrategy {
+	default:
+		return nil, errors.New("unknown pod sorting strategy")
+	}
 }
 
 func evict() (bool, error) {

diff --git a/reaper/options_test.go b/reaper/options_test.go
@@ -279,6 +279,12 @@ func TestOptions(t *testing.T) {
 			sorter(subject)
 			assert.Equal(t, testPodList(), subject)
 		})
+		t.Run("invalid", func(t *testing.T) {
+			os.Clearenv()
+			os.Setenv(envPodSortingStrategy, "not a valid sorting strategy")
+			_, err := podSortingStrategy()
+			assert.Error(t, err)
+		})
 	})
 }