This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
ops/direnv: don’t ignore every connection error #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curiousleo
approved these changes
Jun 30, 2020
We were throwing every single error that could be thrown by a varlink connection into a single bin, even though only one trivial case would mean the socket is not reachable.
Profpatsch
force-pushed
the
ops-direnv-check-varlink-errors
branch
from
eafb147
to
3a41673
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were throwing every single error that could be thrown by a varlink
connection into a single bin, even though only one trivial case would
mean the socket is not reachable.