Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heartbeats: Increase max duration and improve UI for long-durations #3088

Merged
merged 10 commits into from
Jul 19, 2023

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Jun 15, 2023

Description:
This PR updates the heartbeat monitor duration form to make it easier to configure long-lived heartbeats.

Which issue(s) this PR fixes:
Resolves #3015

Screenshots:

screencapture-localhost-3030-services-ba591464-228a-4344-868d-a861ba54b6da-heartbeat-monitors-2023-06-15-13_56_27

screencapture-localhost-3030-services-ba591464-228a-4344-868d-a861ba54b6da-heartbeat-monitors-2023-06-15-13_56_38

Describe any introduced user-facing changes:
Users will now be able to specify timeout values in hours, days, or weeks (in addition to minutes).

Describe any introduced API changes:

  • The max value was increased from 9k minutes to 9k hours.

@mastercactapus mastercactapus marked this pull request as ready for review July 5, 2023 17:43
@github-actions github-actions bot added the size/m label Jul 5, 2023
Copy link
Contributor

@andrewbenington andrewbenington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mastercactapus mastercactapus merged commit 42a54fa into master Jul 19, 2023
6 checks passed
@mastercactapus mastercactapus deleted the hb-better-monitor-duration branch July 19, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Heartbeat Monitor Timeout Units and Limit
4 participants