Skip to content

Commit

Permalink
update escalated count bar to line
Browse files Browse the repository at this point in the history
>
>
Co-authored-by: KatieMSB <katriannasb@gmail.com>
  • Loading branch information
leyasalazar committed Jul 18, 2023
1 parent 06a8ec8 commit b0dce3e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 7 deletions.
15 changes: 11 additions & 4 deletions web/src/app/services/AlertMetrics/AlertCountGraph.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,19 @@ export default function AlertCountGraph(
}}
/>
<Legend />
<Bar
stackId='a'
<Area
dataKey='escalatedCount'
type='monotone'
fill={theme.palette.primary.main}
className={classes.bar}
stroke={
theme.palette.mode === 'light'
? theme.palette.info.dark
: theme.palette.info.light
}
fill={
theme.palette.mode === 'light'
? theme.palette.info.light
: theme.palette.info.dark
}
name='Escalated Alerts'
/>
<Bar
Expand Down
6 changes: 3 additions & 3 deletions web/src/cypress/e2e/services.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,13 @@ function testServices(screen: ScreenFormat): void {
.should('contain', closedAlert.id)
.should('not.contain', openAlert.id)

cy.get('path[name="Alert Count"]')
cy.get('path[name="Alerts"]')
.should('have.length', 1)
.trigger('mouseover')
cy.get('[data-cy=metrics-count-graph]')
.should('contain', now)
.should('contain', 'Alert Count: 1')
.should('contain', 'Escalated: 0') // no ep steps
.should('contain', 'Alerts: 1')
.should('contain', 'Escalated Alerts: 0') // no ep steps
.should('contain', 'Noisy Alerts: 1')

cy.get(`.recharts-line-dots circle[r=3]`).last().trigger('mouseover')
Expand Down

0 comments on commit b0dce3e

Please sign in to comment.