Updates sbt to 1.5.x #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates sbtx. You may notice the commented-out dependency tree plugin. It seems like this plugin may not be available for Scala 2.11. We need to validate shipping for Scala 2.12/2.13 in our internal environment before we increment this publicly.
colindean
requested review from
c-horn,
phpisciuneri and
samratmitra-0812
as code owners
It came out yesterday but SBT's downloads page wasn't updated yet when I checked this morning!
c-horn
approved these changes
Dec 16, 2021
Collaborator
There was a problem hiding this comment.
Spark 2.X will never support scala >2.11 at Target (to my knowledge), spark >2.4 compiles for scala 2.12, we would need to at least bump to 2.4.
EDIT, see: https://search.maven.org/artifact/org.apache.spark/spark-sql_2.12
I'm not sure what the dependency tree plugin thing is doing there, it isn't listed directly:
https://github.com/target/data-validator/blob/master/project/plugins.sbt
It is probably better to remove it either way if we aren't using it for debugging transitive dependencies (it is something I would use from my global plugin config not project level).
samratmitra-0812
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates sbtx.
You may notice the commented-out dependency tree plugin. It seems like this plugin may not be available for Scala 2.11. We need to validate shipping for Scala 2.12/2.13 in our internal environment before we increment this publicly.