Extracted factory data into json files

targendaz2 · Apr 23, 2024 · c6275ed · c6275ed
1 parent 6215a20
commit c6275ed
Show file tree

Hide file tree

Showing 6 changed files with 81 additions and 76 deletions.
diff --git a/tests/factories/data/extensionsAndMIMETypes.json b/tests/factories/data/extensionsAndMIMETypes.json
@@ -0,0 +1,30 @@
+{
+  "aac": "audio/aac",
+  "css": "text/css",
+  "csv": "text/csv",
+  "gif": "image/gif",
+  "gz": "application/gzip",
+  "heic": "image/heic",
+  "heif": "image/heic",
+  "htm": "text/html",
+  "html": "text/html",
+  "jpeg": "image/jpeg",
+  "jpg": "image/jpeg",
+  "js": "text/javascript",
+  "json": "application/json",
+  "m4a": "audio/aac",
+  "md": "text/markdown",
+  "mp4": "video/mp4",
+  "pdf": "application/pdf",
+  "png": "image/png",
+  "rtf": "application/rtf",
+  "tgz": "application/gzip",
+  "tif": "image/tiff",
+  "tiff": "image/tiff",
+  "txt": "text/plain",
+  "xhtml": "application/xhtml+xml",
+  "xml": "application/xml",
+  "yaml": "application/yaml",
+  "yml": "application/yaml",
+  "zip": "application/zip"
+}
diff --git a/tests/factories/data/roles.json b/tests/factories/data/roles.json
@@ -0,0 +1 @@
+["Editor", "Viewer", "Shell", "QLGenerator", "None", "All"]
diff --git a/tests/factories/data/urlSchemes.json b/tests/factories/data/urlSchemes.json
@@ -0,0 +1,37 @@
+[
+  "chrome",
+  "facetime",
+  "fax",
+  "file",
+  "ftp",
+  "git",
+  "http",
+  "https",
+  "imap",
+  "jabber",
+  "ldap",
+  "ldaps",
+  "mailto",
+  "maps",
+  "ms-excel",
+  "ms-powerpoint",
+  "ms-remotedesktop",
+  "ms-word",
+  "msteams",
+  "news",
+  "nfs",
+  "notes",
+  "sftp",
+  "skype",
+  "slack",
+  "smb",
+  "smtp",
+  "spotify",
+  "ssh",
+  "steam",
+  "things",
+  "vnc",
+  "vscode",
+  "webcal",
+  "zoommtg"
+]
diff --git a/tests/factories/documentType.ts b/tests/factories/documentType.ts
@@ -1,49 +1,17 @@
 import type { DocumentType } from '@/src/types';
+import extensionsAndMIMETypes from '@/tests/factories/data/extensionsAndMIMETypes.json';
+import roles from '@/tests/factories/data/roles.json';
 import { faker } from '@faker-js/faker';
 import { Factory } from 'fishery';
 
 class DocumentTypeFactory extends Factory<DocumentType> {}
 
 export const documentTypeFactory = DocumentTypeFactory.define(() => {
-    const [extension, mimeType] = faker.helpers.objectEntry({
-        aac: 'audio/aac',
-        css: 'text/css',
-        csv: 'text/csv',
-        gif: 'image/gif',
-        gz: 'application/gzip',
-        heic: 'image/heic',
-        heif: 'image/heic',
-        htm: 'text/html',
-        html: 'text/html',
-        jpeg: 'image/jpeg',
-        jpg: 'image/jpeg',
-        js: 'text/javascript',
-        json: 'application/json',
-        m4a: 'audio/aac',
-        md: 'text/markdown',
-        mp4: 'video/mp4',
-        pdf: 'application/pdf',
-        png: 'image/png',
-        rtf: 'application/rtf',
-        tgz: 'application/gzip',
-        tif: 'image/tiff',
-        tiff: 'image/tiff',
-        txt: 'text/plain',
-        xhtml: 'application/xhtml+xml',
-        xml: 'application/xml',
-        yaml: 'application/yaml',
-        yml: 'application/yaml',
-        zip: 'application/zip',
-    });
+    const [extension, mimeType] = faker.helpers.objectEntry(
+        extensionsAndMIMETypes,
+    );
 
-    const role = faker.helpers.arrayElement([
-        'Editor',
-        'Viewer',
-        'Shell',
-        'QLGenerator',
-        'None',
-        'All',
-    ]);
+    const role = faker.helpers.arrayElement(roles);
 
     return {
         CFBundleTypeExtensions: [extension],

diff --git a/tests/factories/urlType.ts b/tests/factories/urlType.ts
@@ -1,47 +1,12 @@
 import type { URLType } from '@/src/types';
+import urlSchemes from '@/tests/factories/data/urlSchemes.json';
 import { faker } from '@faker-js/faker';
 import { Factory } from 'fishery';
 
 class URLTypeFactory extends Factory<URLType> {}
 
 export const urlTypeFactory = URLTypeFactory.define(() => {
-    const urlScheme = faker.helpers.arrayElement([
-        'chrome',
-        'facetime',
-        'fax',
-        'file',
-        'ftp',
-        'git',
-        'http',
-        'https',
-        'imap',
-        'jabber',
-        'ldap',
-        'ldaps',
-        'mailto',
-        'maps',
-        'ms-excel',
-        'ms-powerpoint',
-        'ms-remotedesktop',
-        'ms-word',
-        'msteams',
-        'news',
-        'nfs',
-        'notes',
-        'sftp',
-        'skype',
-        'slack',
-        'smb',
-        'smtp',
-        'spotify',
-        'ssh',
-        'steam',
-        'things',
-        'vnc',
-        'vscode',
-        'webcal',
-        'zoommtg',
-    ]);
+    const urlScheme = faker.helpers.arrayElement(urlSchemes);
 
     return {
         CFBundleURLSchemes: [urlScheme],

diff --git a/tests/unit/factories.test.ts b/tests/unit/factories.test.ts
@@ -4,6 +4,7 @@ import {
     infoPlistFactory,
     urlTypeFactory,
 } from '@/tests/factories';
+import extensionsAndMIMETypes from '@/tests/factories/data/extensionsAndMIMETypes.json';
 import { describe, expect, test } from '@jest/globals';
 
 describe('Document Type factory tests', () => {
@@ -15,7 +16,10 @@ describe('Document Type factory tests', () => {
         const documentType = documentTypeFactory.build();
         const extension = documentType.CFBundleTypeExtensions![0];
 
-        expect(documentType.CFBundleTypeMIMETypes![0]).toContain(extension);
+        expect(documentType.CFBundleTypeMIMETypes![0]).toBe(
+            // @ts-expect-error 'eslint thinks this is an any type for some reason'
+            extensionsAndMIMETypes[extension],
+        );
     });
 
     test('generated document type has a role', () => {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		["Editor", "Viewer", "Shell", "QLGenerator", "None", "All"]