-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TARDISData dataclass to hold data about atoms #2812
base: master
Are you sure you want to change the base?
Conversation
*beep* *bop* 3 G004 [ ] Logging statement uses f-string
1 FA102 [*] Missing `from __future__ import annotations`, but uses PEP 604 union
1 G001 [ ] Logging statement uses `str.format`
1 E902 [ ] No such file or directory (os error 2)
1 UP030 [*] Use implicit references for positional format fields
Complete output(might be large): .github/workflows/codespell.yml:1:1: E902 No such file or directory (os error 2)
tardis/io/atom_data/base.py:199:34: G004 Logging statement uses f-string
tardis/io/atom_data/base.py:264:17: G004 Logging statement uses f-string
tardis/io/atom_data/base.py:268:21: UP030 Use implicit references for positional format fields
tardis/io/atom_data/base.py:268:21: G001 Logging statement uses `str.format`
tardis/io/atom_data/base.py:734:17: G004 Logging statement uses f-string
tardis/plasma/assembly/base.py:132:22: FA102 Missing `from __future__ import annotations`, but uses PEP 604 union
Found 7 errors.
No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).
|
So the TARDIS Data class is now mirroring atomic data, correct? I would put it in the a new tardis_data.py package then. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2812 +/- ##
==========================================
- Coverage 70.96% 70.67% -0.30%
==========================================
Files 209 210 +1
Lines 15638 15665 +27
==========================================
- Hits 11098 11071 -27
- Misses 4540 4594 +54 ☔ View full report in Codecov by Sentry. |
📝 Description
Type: 🚀
feature
This class will store the unfiltered data about atoms, ions et al. for the TARDIS plasma and transport. Name suggestions welcome.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label