Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test workflow duplicates test runs #2820

Closed
andrewfullard opened this issue Sep 11, 2024 · 1 comment · Fixed by #2830
Closed

Test workflow duplicates test runs #2820

andrewfullard opened this issue Sep 11, 2024 · 1 comment · Fixed by #2830
Assignees
@KasukabeDefenceForce
Labels
CI/CD testing 🚦

Comments

@andrewfullard
Copy link
Contributor

The test workflow is set up as

on:
  push:
    branches:
      - "*"
  pull_request:
    branches:
      - "*"

which duplicates actions across pushes and PR opens. It would be better set up following our other checks to reduce duplication.
@github-project-automation github-project-automation bot moved this to Todo in DevOps Sep 11, 2024
@andrewfullard
Copy link
Contributor Author

c.f. https://github.com/orgs/community/discussions/26940

@atharva-2001 atharva-2001 linked a pull request Sep 30, 2024 that will close this issue
Fix for #2820 #2830
Merged
6 tasks
andrewfullard pushed a commit that referenced this issue Sep 30, 2024
@atharva-2001
Fix for #2820 (#2830)
60006d5 
Make sure tests only run when push to master and pull request to master
@github-project-automation github-project-automation bot moved this from Todo to Done in DevOps Sep 30, 2024
CePowers pushed a commit to CePowers/tardis that referenced this issue Oct 1, 2024
@atharva-2001 @CePowers
Fix for tardis-sn#2820 (tardis-sn#2830)
1a3da95 
Make sure tests only run when push to master and pull request to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KasukabeDefenceForce KasukabeDefenceForce

Labels
CI/CD testing 🚦
Projects
DevOps
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #2820 atharva-2001/tardis
2 participants
@andrewfullard @KasukabeDefenceForce