-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export raw Chianti collision and A_ul data instead of pre-processing #414
Draft
andrewfullard
wants to merge
7
commits into
master
Choose a base branch
from
chianti_collision_raw
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 66.68% 67.38% +0.70%
==========================================
Files 46 46
Lines 3497 3462 -35
==========================================
+ Hits 2332 2333 +1
+ Misses 1165 1129 -36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewfullard
commented
Nov 4, 2024
andrewfullard
commented
Nov 4, 2024
andrewfullard
changed the title
Export raw Chianti collision data instead of pre-processing
Export raw Chianti collision and A_ul data instead of pre-processing
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: ☣️
breaking change
The Chianti data was previously processed in Carsus to work with TARDIS. With the latest changes to TARDIS in tardis-sn/tardis#2770 this will not be necessary, and TARDIS will handle the processing.
For the Einstein A_ul coefficients, Chianti has some levels with gf = 0. This means that A_ul is computed to be zero even if the levels are included. Changes in this PR allow the Chianti A_ul values to be retained. This probably breaks for CMFGEN data.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label