Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export raw Chianti collision and A_ul data instead of pre-processing #414

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Oct 1, 2024

📝 Description

Type: ☣️ breaking change

The Chianti data was previously processed in Carsus to work with TARDIS. With the latest changes to TARDIS in tardis-sn/tardis#2770 this will not be necessary, and TARDIS will handle the processing.

For the Einstein A_ul coefficients, Chianti has some levels with gf = 0. This means that A_ul is computed to be zero even if the levels are included. Changes in this PR allow the Chianti A_ul values to be retained. This probably breaks for CMFGEN data.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.38%. Comparing base (3403655) to head (b79d73b).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
carsus/io/output/levels_lines.py 0.00% 6 Missing ⚠️
carsus/io/output/collisions.py 0.00% 3 Missing ⚠️
carsus/io/output/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   66.68%   67.38%   +0.70%     
==========================================
  Files          46       46              
  Lines        3497     3462      -35     
==========================================
+ Hits         2332     2333       +1     
+ Misses       1165     1129      -36     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewfullard andrewfullard changed the title Export raw Chianti collision data instead of pre-processing Export raw Chianti collision and A_ul data instead of pre-processing Nov 4, 2024
@wkerzendorf wkerzendorf marked this pull request as draft November 11, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant