Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes collision export for TARDIS #412

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Sep 25, 2024

📝 Description

Type: 🪲 bugfix

Fixes #411 by correctly pointing to the collision preparer.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (3403655) to head (816737f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #412   +/-   ##
=======================================
  Coverage   66.68%   66.68%           
=======================================
  Files          46       46           
  Lines        3497     3497           
=======================================
  Hits         2332     2332           
  Misses       1165     1165           
Flag Coverage Δ
66.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewfullard andrewfullard merged commit ef11c8d into master Nov 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collisional data cannot be exported from Carsus
4 participants