Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NNDC Reader optional #369

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Make NNDC Reader optional #369

merged 1 commit into from
Aug 23, 2023

Conversation

shreyas3156
Copy link
Member

📝 Description

Type: 🪲 bugfix

This PR makes having the NNDCReader object optional while creating the atomic data HDF output.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

@andrewfullard andrewfullard merged commit 4a3b39e into tardis-sn:master Aug 23, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atharva-2001 atharva-2001 atharva-2001 approved these changes

@andrewfullard andrewfullard andrewfullard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shreyas3156 @andrewfullard @atharva-2001