Add carsus-data-nndc github URL #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewfullard
approved these changes
Aug 3, 2023
shreyas3156
force-pushed
the
add-nndc-github-mirror
branch
from
75fbbd5
to
1a9ba5a
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🚀
featureThis clones the carsus-data-nndc when there is no local source of the NNDC CSV data present. The
NNDCReaderclass gets another attributeremotewhich needs to be set toTruewhen the github mirror is to be used.The test includes cloning the repository and deleting it at the end of the test.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel