replicaset: log replica in connection triggers #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, only the host and port were written to logs on connection or disconnection. However, it was very difficult to figure out to which replica we connected/disconnected, which made debugging the logs frustrating. Let's instead log the full replica object, which includes the replica id and its URI. NO_DOC=refactoring
Serpentian
force-pushed
the
log-replica-on-connect-disconnect
branch
from
acd3e7c to
4e90d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, only the host and port were written to logs on connection or disconnection. However, it was very difficult to figure out to which replica we connected/disconnected, which made debugging the logs frustrating. Let's instead log the full replica object, which includes the replica id and its URI.