Skip to content

Introduce real assert for tests #444

Open

Description

Lua assert() won't kill the process, it only throws an error. For testing it might be better to have a real assert which would abort the process when fails. We could put it into vshard.util.assert() or something alike. In tests it would be redefined to call C function abort() (in test/instances/storage.lua and router.lua). Then we would more reliably catch all asserts which now might go unnoticed, especially when fail inside background services. By default we would keep it equal to Lua assert().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions