iproto: introduce IPROTO_INSERT_ARROW request
#10518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gumix
force-pushed
the
iverbin/gh-10508-iproto_insert_arrow
branch
from
2478f54 to
f68db29
Compare
p7nov
reviewed
Sep 5, 2024
p7nov
approved these changes
Sep 5, 2024
ligurio
reviewed
Sep 5, 2024
mkostoevr
reviewed
Sep 5, 2024
Gumix
force-pushed
the
iverbin/gh-10508-iproto_insert_arrow
branch
from
f68db29 to
0be0526
Compare
mkostoevr
approved these changes
Sep 9, 2024
locker
requested changes
Sep 9, 2024
locker
requested changes
Sep 9, 2024
Gumix
force-pushed
the
iverbin/gh-10508-iproto_insert_arrow
branch
from
0be0526 to
333dfd7
Compare
Gumix
force-pushed
the
iverbin/gh-10508-iproto_insert_arrow
branch
from
333dfd7 to
6479154
Compare
locker
reviewed
Sep 11, 2024
Gumix
force-pushed
the
iverbin/gh-10508-iproto_insert_arrow
branch
from
6479154 to
b3b2c7e
Compare
locker
approved these changes
Sep 11, 2024
Gumix
force-pushed
the
iverbin/gh-10508-iproto_insert_arrow
branch
from
b3b2c7e to
899252d
Compare
|
Bumped nanoarrow to bring compilation fix. |
Gumix
force-pushed
the
iverbin/gh-10508-iproto_insert_arrow
branch
from
5f4bec5 to
72f1c28
Compare
The nanoarrow library is required to work with the serialized Arrow IPC format [1]. 1. https://arrow.apache.org/docs/format/Columnar.html#serialization-and-interprocess-communication-ipc Needed for tarantool#10508 Needed for tarantool/tarantool-ee#820 NO_DOC=third_party NO_TEST=third_party NO_CHANGELOG=third_party
Also the NULL assignments are replaced by the assertions, as the `iproto_thread` structure is allocated by `calloc()`. NO_DOC=refactoring NO_TEST=refactoring NO_CHANGELOG=refactoring
The new method inserts into a given space the data, provided in Arrow columnar format [1]. At the moment it is not supported by memtx and vinyl spaces. Also the IPROTO_INSERT_ARROW request is introduced. It inserts the data that is serialized into Arrow IPC format [2]. 1. https://arrow.apache.org/docs/format/Columnar.html 2. https://arrow.apache.org/docs/format/Columnar.html#serialization-and-interprocess-communication-ipc Closes tarantool#10508 Needed for tarantool/tarantool-ee#820 NO_CHANGELOG=No sense in mentioning in CE release notes @TarantoolBot document Title: Document iproto request IPROTO_INSERT_ARROW Product: Tarantool Since: 3.3 Root documents: https://www.tarantool.io/en/doc/latest/reference/internals/iproto/requests/ https://www.tarantool.io/en/doc/latest/reference/internals/iproto/keys/#internals-iproto-keys-features Available IPROTO_FEATURES are the following: * IPROTO_FEATURE_INSERT_ARROW = 12 - Support of data insertion in Arrow format. IPROTO version supporting the this feature is 10 or newer. Client-server requests and responses: * IPROTO_INSERT_ARROW = 0x11 - Insert Arrow data request. The structure of the `IPROTO_INSERT_ARROW` request is similar to `IPROTO_INSERT`, the only difference is `IPROTO_ARROW : MP_ARROW` instead of `IPROTO_TUPLE : MP_ARRAY`. The response to `IPROTO_INSERT_ARROW` contains an empty body.
Gumix
force-pushed
the
iverbin/gh-10508-iproto_insert_arrow
branch
from
72f1c28 to
1189cc8
Compare
|
Rewrote |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new request inserts into a given space the data that is encoded into Arrow IPC columnar format 1.
At the moment the request is not supported by memtx and vinyl spaces.
Closes #10508
Needed for https://github.com/tarantool/tarantool-ee/issues/820
Footnotes
https://arrow.apache.org/docs/format/Columnar.html#serialization-and-interprocess-communication-ipc ↩