support for new format indexes #96
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbes
requested changes
Jan 25, 2018
| @@ -134,7 +136,7 @@ def close(self): | |||
| self._socket = None | |||
|
|
|||
| def connect_basic(self): | |||
| if self.host == None: | |||
| if self.socket: | |||
There was a problem hiding this comment.
Why're you doing this incompatible changes? use separate PR's for them.
There was a problem hiding this comment.
Sorry, I'll send another PR for this. I thought this repo no longer active
| @@ -26,8 +26,11 @@ def __init__(self, index_row, space): | |||
| self.unique = index_row[4] | |||
| self.parts = [] | |||
| if isinstance(index_row[5], (list, tuple)): | |||
| for k, v in index_row[5]: | |||
| self.parts.append((k, v)) | |||
| for part in range(len(index_row[5])): | |||
There was a problem hiding this comment.
Please, add tests for this part of code
There was a problem hiding this comment.
OK. But, I've changed format of parts to dict {'field': part[0], 'type': part[1]}, because for me parts doesn't matter. I don't use them. But this change brokes backward compatibility. So, I should do this by older way? I mean like this:
if isinstance(part, list):
self.parts.append((part[0], part[1]))
else:
self.parts.append((part['field'], part['type']))
|
I created another PR with tests. Because changes in this PR not relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix issue #95