Skip to content

Fix lint #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Fix lint #314

merged 4 commits into from
Oct 3, 2023

Conversation

DifferentialOrange
Copy link
Member

No description provided.

Disable newly uncovered cases of R0913 too-many-arguments. We don't plan
to change existing public API now.

Since pylint 3.0.0, issue [1] has been fixed, which uncovered several
new too-many-arguments cases.

1. pylint-dev/pylint#8667
Disable unnecessary-lambda lint warning in test. The warning had been
uncovered since pylint 3.0.0, but it's not clear what exactly is
the reason since the only CHANGELOG entry related to unnecessary-lambda
declares that false positive cases were fixed [1].

1. pylint-dev/pylint#8496
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/fix-failing-lint branch 3 times, most recently from e9a6197 to 1897c7d Compare October 3, 2023 11:18
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/fix-failing-lint branch 3 times, most recently from f4e01d8 to 1a813d7 Compare October 3, 2023 11:43
Version lock is based on a latest version available for specific Python.
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/fix-failing-lint branch from 1a813d7 to 5198b07 Compare October 3, 2023 11:47
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry?

Copy link
Member

@0x501D 0x501D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DifferentialOrange
Copy link
Member Author

DifferentialOrange commented Oct 3, 2023

Changelog entry?

Not sure any change worth it: too internal

@DifferentialOrange DifferentialOrange merged commit 3c8eb9d into master Oct 3, 2023
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/fix-failing-lint branch October 3, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants