test: wait until admin connection is ready #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
force-pushed
the
DifferentialOrange/fix-flaky-missing-user
branch
from
fa0eb3c to
b9b0905
Compare
Current `wait_until_started` method wait till `box.info.status` is "running" and start sending requests. Such approach is wrong: status "running" [1] does not guarantees that instance is available for writing (like creating new users) [2]. It results in flaky test results (for example, see 4 restarts in [3]). This patch fixes the issue. After this patch, it is guaranteed that after `wait_until_ready` call instance had finished to run its initialization script, including box.cfg, and available for writing data if it is expected to be able to. Windows instances use a separate lock mechanism, so this patch is not related to Windows instances. 1. https://github.com/tarantool/tarantool/blob/983a7ec215d46b6d02935d1baa8bbe07fc371795/src/box/box.cc#L5425-L5426 2. https://github.com/tarantool/tarantool/blob/983a7ec215d46b6d02935d1baa8bbe07fc371795/src/box/box.cc#L5454 3. https://github.com/tarantool/tarantool/actions/runs/5759802620
DifferentialOrange
force-pushed
the
DifferentialOrange/fix-flaky-missing-user
branch
2 times, most recently
from
98d0208 to
98bf93c
Compare
Some installation certificates are outdated for Ubuntu 22.04.
DifferentialOrange
force-pushed
the
DifferentialOrange/fix-flaky-missing-user
branch
2 times, most recently
from
035ca72 to
5cc07fd
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/fix-flaky-missing-user
branch
4 times, most recently
from
525a1a8 to
84afb05
Compare
Admin command are sent through text protocol. Responses are rarely processed, especially those which sets up schema and users. But such requests can contain errors, like "already exists" or syntax ones. Having asserts on schema set up makes it easier to debug some cases. For example, it was helpful in discovering the reason behind "user not exists" fails fixed in "wait until server is ready" patchset commit [1]. 1. https://github.com/tarantool/tarantool-python/actions/runs/5784619729/job/15675655683?pr=306
`null` is a common variable in Lua. Since the variable is not declared and strict mode is off, it is essentially `nil`.
DifferentialOrange
force-pushed
the
DifferentialOrange/fix-flaky-missing-user
branch
from
84afb05 to
a6db2d4
Compare
GRISHNOV
approved these changes
Aug 8, 2023
DifferentialOrange
deleted the
DifferentialOrange/fix-flaky-missing-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes flaky server startup and adds asserts to simplify possible debug in the future. See commits for more info.