php8 compat #170
Closed
php8 compat #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll glance when the time will permit. At least I would add the new PHP version into CI. |
|
umh, while I am sure this worked fine with php8.0 and older tarantool 2.x, unfortunately it is not enough for php8.1 and tarantool 2.10. when doing select() on some spaces, we get "ER_INVALID_MSGPACK: Invalid MsgPack - packet body", and I dont have the knowledge to investigate that one. it seems tarantool-php/client is the recommended way now, and we'll have to move. I'll just close this PR and let someone with more knowledge than me fix tarantool-php when the time comes. apologies for the noise this PR have created. |
|
If you can move to tarantool-php/client, that's the preferred option. It is my fault. Something always sift out of hands. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ as title says