Skip to content

Deprecate upsert with a key (from tarantool 1.6.6) #248

Open
@Totktonada

Description

@Totktonada

Tarantool-java version: 1.9.3.

Cited from Tarantool 1.6.7 release notes:

The syntax of upsert command has been changed and an extra key argument was removed from it. The primary key for look up is now always taken from the tuple, which is the second argument of upsert. upsert() was added fairly late at a release cycle and the design had an obvious bug which we had to fix. Sorry for this.

See also tarantool/tarantool#1070

The connector provides upsert() method with a key argument:

public Result upsert(Space space, Tuple key, Tuple def, Operation... args) {
return exec(Code.UPSERT, Key.SPACE, space, Key.KEY, key, Key.TUPLE, def, Key.UPSERT_OPS, args);
}

This is harmless, because those arguments are packed into a map and deprecated key field is ignored by tarantool 1.6.7 and above. However this API can confuse a user.

I propose to overload upsert method w/o key argument to don't bother a user with providing some value for key. This will also save some CPU cycles on encoding a request and several bytes in outgoing packets.

We also should cleanly state in javadoc that the old upsert method is deprecated and should be used only for tarantool 1.6.6 and below. We cannot remove the method, because the connector should be backward compatible.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions