Merged
Conversation
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-55-metrics
branch
2 times, most recently
from
0fb5ebb to
e3cf94d
Compare
Member
DifferentialOrange
left a comment
DifferentialOrange
left a comment
There was a problem hiding this comment.
Thank you for the updates. Seems mostly fine, I'll approve the PR after resolving remaining comments.
The patch adds the ability to export statistics to metrics >= 0.11.0.
sharded_queue does not require the metrics package itself and tries
to use an installed one.
It also adds a new API method api.cfg({options}).
Exported metric values are similar to api.statistics(tube) call:
* sharded_queue_calls
* sharded_queue_tasks
Closes #55
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-55-metrics
branch
from
e3cf94d to
4878b95
Compare
DifferentialOrange
approved these changes
Jun 15, 2023
better0fdead
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch adds the ability to export statistics to metrics >= 0.11.0.
sharded_queue does not require the metrics package itself and tries
to use an installed one.
It also adds a new API method api.cfg({options}).
Exported metric values are similar to api.statistics(tube) call:
Closes #55