replicaset_mode: fix queue.tube indexes #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x501D
force-pushed
the
0x501D/fix_gh_202
branch
from
0347ba5 to
b80e616
Compare
LeonidVas
approved these changes
Mar 7, 2023
In replicaset mode, tubes can be created and deleted on different nodes. Accordingly, it is necessary to rebuild the queue.tube index. Closes #202
0x501D
force-pushed
the
0x501D/fix_gh_202
branch
from
b80e616 to
c88fdea
Compare
Fixed. |
oleg-jukovec
approved these changes
Mar 7, 2023
Comment on lines
+550
to
+554
| for _, tube_tuple in box.space._queue:pairs() do | ||
| if queue.driver[tube_tuple[4]] ~= nil then | ||
| recreate_tube(tube_tuple) | ||
| end | ||
| end |
There was a problem hiding this comment.
You could extract it in a separate function: recreate_tubes. The code appears at least two times in the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In replicaset mode, tubes can be created and deleted on different nodes. Accordingly, it is necessary to rebuild the queue.tube index.
Close #202