Skip to content

mariadb-connector-c: fix build with cmake 3.20+ #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

ylobankov
Copy link
Contributor

@ylobankov ylobankov commented Nov 1, 2021

This change is intended to resolve the issue when cmake 3.20+ is
installed in your system and in this case it's impossible to build
the mysql module because the following error occurs:

CMake Error at mariadb-connector-c/cmake/ConnectorName.cmake:30 (ENDMACRO):
  Flow control statements are not properly nested.
Call Stack (most recent call first):
  mariadb-connector-c/CMakeLists.txt:391 (INCLUDE)

So this patch updates the mariadb-connector-c submodule to the version
where the fix to resolve the mentioned error is applied.

Fixes #59

@ylobankov ylobankov requested a review from Totktonada November 1, 2021 15:35
@ylobankov ylobankov force-pushed the ylobankov/update-submodule-version branch from ac8c7d8 to 996be33 Compare November 1, 2021 15:50
This change is intended to resolve the issue when cmake 3.20+ is
installed in your system and in this case it's impossible to build
the mysql module because the following error occurs:

    CMake Error at mariadb-connector-c/cmake/ConnectorName.cmake:30 (ENDMACRO):
      Flow control statements are not properly nested.
    Call Stack (most recent call first):
      mariadb-connector-c/CMakeLists.txt:391 (INCLUDE)

So this patch updates the mariadb-connector-c submodule to the version
where the fix to resolve the mentioned error is applied.

Fixes #59
@ylobankov ylobankov force-pushed the ylobankov/update-submodule-version branch from 996be33 to 4ca36b1 Compare November 1, 2021 16:20
@ylobankov ylobankov changed the title Update submodule version to 2e89e24 mariadb-connector-c: fix build with cmake 3.20+ Nov 1, 2021
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Totktonada Totktonada merged commit 7985963 into master Nov 1, 2021
@Totktonada Totktonada deleted the ylobankov/update-submodule-version branch November 1, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build mysql module when cmake 3.20+ is used
2 participants