Update documentation and conn:reset() #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "return error()" is used in Lua, an exception will be thrown. Let's clarify this point in the documentation and code.
|
I didn't look thoroughly, to be honest, but I don't see anything dangerous and so it should be okay. I would only return an error from driver.c and raise it from init.lua to eliminate extra pcall and to keep driver.c API more or less consistent (at least it returns an error from execute()). |
Totktonada
approved these changes
Oct 5, 2020
…settings We don't check the result of updating the connection authentication settings in the conn: reset() method and failure will be detected only when trying to execute a request. But in programming, it is a good practice to check the result of the function. The patch adds a check on the result of updating the connection authentication settings. On failure, an exception will be thrown.
LeonidVas
force-pushed
the
lvasiliev/gh-no-ticket-cleanup-mysql
branch
from
5581450 to
690cf46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patchset includes:
ChangeLog:
Added a check for the result of updating the connection authentication settings.