Handle connections from a pool #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonidVas
force-pushed
the
lvasiliev/gh-33-handle-connections-from-pool
branch
from
717046d to
2e10033
Compare
LeonidVas
force-pushed
the
lvasiliev/gh-33-handle-connections-from-pool
branch
2 times, most recently
from
f9e8508 to
54e70d2
Compare
Totktonada
reviewed
Sep 25, 2020
Totktonada
reviewed
Sep 28, 2020
LeonidVas
force-pushed
the
lvasiliev/gh-33-handle-connections-from-pool
branch
from
54e70d2 to
adc3874
Compare
Totktonada
reviewed
Oct 14, 2020
Justification for code cleanup: * To make the code easier to understand, the variable is declared inside the scope where it will be used. * Remove unnecessary recheck.
If the connection belongs to a connection pool, it must be returned to the pool when calling "close" without actually closing the connection. All connections will be closed when poll:close() will be called. The same behavior is used in JDBC connection pool. With this change, an attempt to "put" an unusable connection is no longer valid. Code that doesn't test anything has been removed from the tests. Fixed #33
Before the patch pool: close () return fixed "number" == 1. This seems to mean "no errors". So let's use the same return type as for the connection: close (). This will be more consistent.
LeonidVas
force-pushed
the
lvasiliev/gh-33-handle-connections-from-pool
branch
from
adc3874 to
f2c9ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patchset includes:
Fixed #33
ChangeLog:
Update connection management for connection pool.
Change the return type of pool:close() to bool.