api: add hardcoded versioning support #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: |
GRISHNOV
force-pushed
the
igrishnov/gh-204-add-hardcoded-versioning-support
branch
from
c38e945 to
ef31f34
Compare
Added the _VERSION variable to the exported table. Is part of the task [1]. 1. github.com/tarantool/roadmap-internal/issues/204
GRISHNOV
force-pushed
the
igrishnov/gh-204-add-hardcoded-versioning-support
branch
from
ef31f34 to
eaf7c3f
Compare
DifferentialOrange
approved these changes
Mar 15, 2023
It seems like it could be fixed with one-line commit. Let's do it |
|
Bump test workflow OS to Ubuntu 20.04 and install gcc/g++. If there are more work will be discovered, let's ignore it. |
GRISHNOV
force-pushed
the
igrishnov/gh-204-add-hardcoded-versioning-support
branch
from
d69fc6a to
766bd09
Compare
DifferentialOrange
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Let's not fix CI any longer. File an issue, tarantool/http@c08227d is likely to be the reason. You may also add test xfail/skip to get a green light.
GRISHNOV
force-pushed
the
igrishnov/gh-204-add-hardcoded-versioning-support
branch
from
766bd09 to
eaf7c3f
Compare
Done |
Git222 is deprecated. Also, to build dependent modules, an ubuntu bump was needed and added gcc/gcc-c++ to centos packages installation.
DifferentialOrange
force-pushed
the
igrishnov/gh-204-add-hardcoded-versioning-support
branch
from
37b7adb to
b275349
Compare
DifferentialOrange
deleted the
igrishnov/gh-204-add-hardcoded-versioning-support
branch
DifferentialOrange
added a commit
that referenced
this pull request
Mar 20, 2023
Overview This release introduces new API to check module version in code. New features * Add versioning support (PR #62).
Merged
DifferentialOrange
added a commit
that referenced
this pull request
Mar 22, 2023
Overview This release introduces new API to check module version in code. New features * Add versioning support (PR #62).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add versioning support, now the module api has
_VERSIONhardcoded variable. Is part of the task [1].