Skip to content

Migrate Python tests to Lua #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 27, 2025
Merged

Migrate Python tests to Lua #82

merged 15 commits into from
May 27, 2025

Conversation

p0rtale
Copy link
Contributor

@p0rtale p0rtale commented May 22, 2025

Converted all Python-based tests to Lua except:

  • test/test_probe_uri.py
  • test/test_reload.py

@p0rtale p0rtale requested a review from yngvar-antonsson May 22, 2025 10:16
@yngvar-antonsson yngvar-antonsson requested a review from Copilot May 26, 2025 08:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates existing Python tests to Lua, introduces new Lua integration tests, updates test helpers, and adjusts the CI pipeline to run Lua-based tests.

  • Add comprehensive Lua integration tests covering synchronization, subscription, quitting/rejoining, payloads, clock skew, initialization flows, false rumors, encryption, dissemination, self-dead detection, broadcasting, and allowed-members filtering.
  • Extend test helpers in server.lua, instance.lua, and cluster2.lua with new methods and refine startup/teardown logic.
  • Update GitHub Actions workflow to install dependencies, set up Tarantool, run luacheck, build the project, and execute tests via luatest.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test_lua/integration/*.lua New Lua integration tests replacing Python ones
test_lua/helpers/server.lua Added add_member, probe_uri, broadcast, etc. methods
test_lua/helpers/instance.lua Adjust default WAL/vinyl directory defaults and grants
test_lua/helpers/cluster2.lua Introduce hostname arg, port checks, environment vars
.github/workflows/test.yml Switch to Lua setup, install rocks, run luacheck & luatest

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@yngvar-antonsson
Copy link
Contributor

Well done, @p0rtale ! Titanic work here. I've added a couple of notes.

@p0rtale p0rtale requested a review from yngvar-antonsson May 27, 2025 11:44
@yngvar-antonsson yngvar-antonsson merged commit 316bbab into master May 27, 2025
3 checks passed
@yngvar-antonsson yngvar-antonsson deleted the lua-tests branch May 27, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants