Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/box: first box and box.info implementation #414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KaymeKaydex
Copy link

@KaymeKaydex KaymeKaydex commented Oct 19, 2024

I implemented the box interface for tarantool with a small number of fields, which in the future can be supplemented

I didn't forget about (remove if it is not applicable):

Related issues: #410

@KaymeKaydex KaymeKaydex force-pushed the feature/box branch 9 times, most recently from c643841 to 5d9ad18 Compare October 19, 2024 13:55
implemented the box interface for tarantool with a small number of fields, which in the future can be supplemented
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with this approach is that it cannot be extended. As example:

  1. How to use a context with the method? How to cancel the request?
  2. How to make an async request?

It's better to implement a custom request type, as it is already done in the crud and the arrow subpackages. It is possible to implement a custom response type for a request too:

exResp, ok := resp.(*tarantool.ExecuteResponse)

Comment on lines +28 to +29
// Cluster information, including cluster UUID.
Cluster ClusterInfo `msgpack:"cluster"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Tarantool 3 the field has name replicaset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants