crud: allow interface{} as values for *ManyRequest #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-365-crud-typed-batches
branch
2 times, most recently
from
77d65e8
to
fe01ab9
Compare
oleg-jukovec
changed the title
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-365-crud-typed-batches
branch
2 times, most recently
from
04fd0e8
to
ba46e3e
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-365-crud-typed-batches
branch
from
ba46e3e
to
2860690
Compare
Closed
DerekBum
approved these changes
Jan 29, 2024
It was a mistake to use `[]interface{}` or `[]msgpack.CustomEncoder`
as types for an array of tuples or an array of objects. Users were
unable to use slices of custom types as incoming values.
The patch now allows the use of `interface{}` as incoming values. It
makes it easier to use the API, but users need to be more careful.
Therefore, we have also added examples.
Closes #365
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-365-crud-typed-batches
branch
from
2860690
to
906765f
Compare
DifferentialOrange
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a mistake to use
[]interface{}or[]msgpack.CustomEncoderas types for an array of tuples or an array of objects. Users were unable to use slices of custom types as incoming values.The patch now allows the use of
interface{}as incoming values. It makes it easier to use the API, but users need to be more careful. Therefore, we have also added examples.Closes #365