api: fix splice update operation #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekBum
force-pushed
the
DerekBum/gh-348-fix-splice-update-operation
branch
from
15cb5f6
to
ab4af57
Compare
test_helpers/utils.go
Outdated
| @@ -200,6 +200,14 @@ func SkipIfWatchOnceUnsupported(t *testing.T) { | |||
| SkipIfFeatureUnsupported(t, "watch once", 3, 0, 0) | |||
| } | |||
|
|
|||
| // SkipIfCrudSpliceUnsupported skips test run if Tarantool without support of | |||
| // crud splice update operation is used. | |||
There was a problem hiding this comment.
crud splice is core Tarantool splice
There was a problem hiding this comment.
But for some reason, using splice in crud is not supported for Tarantool < 2.0. While we can use splice from the core.
There was a problem hiding this comment.
Can you show the exact error?
There was a problem hiding this comment.
Sure. For example:
https://github.com/tarantool/go-tarantool/actions/runs/6875782438/job/18700075402
--- FAIL: TestCrudProcessData/Update (0.00s)
tarantool_test.go:583: Failed to perform CRUD request on CRUD side: map[interface {}]interface {}{"class_name":"UpdateError", "err":"Failed to update: Unknown UPDATE operation", "file":"...ool/crud/testdata/.rocks/share/tarantool/crud/update.lua", "line":0xb0, "str":"UpdateError: Failed to update: Unknown UPDATE operation"}
But for the core:
PASS
ok github.com/tarantool/go-tarantool/v2 4.867s
There was a problem hiding this comment.
It seems that this one is more "broken" than "unsupported": tarantool/crud#397
Thank for the report. I think it's worth to add a link to the issue to skip helper.
There was a problem hiding this comment.
Updated function name and added a link to an issue.
DerekBum
force-pushed
the
DerekBum/gh-348-fix-splice-update-operation
branch
from
ab4af57
to
fa47071
Compare
oleg-jukovec
approved these changes
Nov 16, 2023
DerekBum
force-pushed
the
DerekBum/gh-348-fix-splice-update-operation
branch
3 times, most recently
from
5c6ff3a
to
00fa43c
Compare
oleg-jukovec
approved these changes
Nov 16, 2023
DerekBum
force-pushed
the
DerekBum/gh-348-fix-splice-update-operation
branch
from
00fa43c
to
3a1a237
Compare
DifferentialOrange
approved these changes
Nov 17, 2023
Splice update operation (`:`) accepts 5 and only 5 arguments. It was parsed and encoded incorrectly with only 3 argument (as every other update operations). Also fixed the same operation for the crud. Part of #348
`Op` struct made private.
Change all `Upsert` and `Update` requests to accept
`*tarantool.Operations` as `ops` parameters instead of
`interface{}`.
Closes #348
DerekBum
force-pushed
the
DerekBum/gh-348-fix-splice-update-operation
branch
from
3a1a237
to
56b3c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splice update operation (
:) accepts 5 and only 5 arguments. It was parsed and encoded incorrectly with only 3 argument (as every other update operations).Also fixed the same operation for the crud.
Opstruct made private.Change all
UpsertandUpdaterequests to accept*tarantool.Operationsasopsparameters instead of theinterface{}.I didn't forget about (remove if it is not applicable):
Closes #348