Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crud: bump rocks minor version with compatibility fixes #339

Merged

Conversation

CuriousGeorgiy
Copy link
Member

@CuriousGeorgiy CuriousGeorgiy commented Oct 24, 2023

Needed for tarantool/tarantool#8147

Related issues:

@CuriousGeorgiy CuriousGeorgiy added the do not merge Not ready to be merged label Oct 24, 2023
if: matrix.tarantool == 'pr/8630'
run: |
tt init
tt install tarantool pr/8630
Copy link
Member

@DifferentialOrange DifferentialOrange Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.x latest setup uses sudo tt install, you may need this too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow succeeded, looks like sudo is unnecessary.

CHANGELOG.md Outdated
@@ -20,6 +20,7 @@ Versioning](http://semver.org/spec/v2.0.0.html) except to the first release.
- Support `fetch_latest_metadata` option for crud requests with metadata (#335)
- Support `noreturn` option for data change crud requests (#335)
- Support `crud.schema` request (#336)
- Support Tarantool tuples over IPROTO in crud (#337)
Copy link
Member

@DifferentialOrange DifferentialOrange Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go-tarantool does not depends on crud, the fix is related only to the test infrastructure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@CuriousGeorgiy
Copy link
Member Author

CI on tarantool/tarantool#8630 succeeded.

@CuriousGeorgiy CuriousGeorgiy changed the title crud: support Tarantool tuples over IPROTO crud: bump rocks minor version with compatibility fixes Needed for tarantool/tarantool#8147 Oct 24, 2023
@CuriousGeorgiy CuriousGeorgiy changed the title crud: bump rocks minor version with compatibility fixes Needed for tarantool/tarantool#8147 crud: bump rocks minor version with compatibility fixes Oct 24, 2023
@CuriousGeorgiy CuriousGeorgiy removed the do not merge Not ready to be merged label Oct 24, 2023
@oleg-jukovec
Copy link
Collaborator

Thank you for the patch!

@oleg-jukovec oleg-jukovec merged commit b6e8aba into tarantool:master Oct 24, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants