Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.12.1 #325

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Release 1.12.1 #325

merged 6 commits into from
Aug 7, 2023

Conversation

oleg-jukovec
Copy link
Collaborator

@oleg-jukovec oleg-jukovec commented Aug 3, 2023

Overview

The patch release imports fixes from the master branch.

Breaking changes

There are no breaking changes in the release.

Bugfixes

Other

oleg-jukovec and others added 6 commits August 3, 2023 14:22
We forgot to increase the timeout [1] when we fixed tests for macos.

1. 521c0c3

(cherry picked from 6cddcd7)
The identify() function expects the UUID argument to be a plain string
while the go connector encodes it in MsgPack as a binary blob (MP_BIN).
This works fine for now because Tarantool stores MP_BIN data in a string
when decoded to Lua but this behavior is going to change soon: we're
planning to introduce the new Lua type for binary data and update the
MsgPack decoder to store MP_BIN data in a varbianry object instead of
a plain string.

Let's prepare for that by converting the UUID data to a string before
encoding.

Needed for tarantool/tarantool#1629

(cherry picked from c2498be)
The `r.current` value can be changed by concurrent threads because
the change happens under read-lock. We could use the atomic counter
for a current connection number to avoid the race condition.

Closes #309

(cherry picked from dbfaab5)
The `scale` value in `MP_DECIMAL` may be negative [1]. We need
to handle the case.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/msgpack_extensions/#the-decimal-type

(cherry picked from 3aeb8c2)
The patch fixes a typo that made it impossible to setup
SelectOpts.After, SelectOpts.BatchSize and SelectOpts.ForceMapCall.

Part of #320

(cherry picked from f56fb90)
Overview

    The patch release imports fixes from the master branch.

Breaking changes

    There are no breaking changes in the release.

Bugfixes

    Flaky decimal/TestSelect (#300).

    Race condition at roundRobinStrategy.GetNextConnection() (#309).

    Incorrect decoding of an MP_DECIMAL when the `scale` value is
    negative (#314).

    Incorrect options (`after`, `batch_size` and `force_map_call`)
    setup for crud.SelectRequest (#320).

Other

    Change encoding of the queue.Identify() UUID argument from binary
    blob to plain string. Needed for upgrade to Tarantool 3.0, where a
    binary blob is decoded to a varbinary object (#313).
@siller174
Copy link

thank you

@oleg-jukovec oleg-jukovec marked this pull request as ready for review August 3, 2023 12:23
@oleg-jukovec oleg-jukovec merged commit 461ad48 into release/1.12 Aug 7, 2023
22 checks passed
@oleg-jukovec oleg-jukovec deleted the oleg-jukovec/release-1.12.1 branch August 7, 2023 11:46
@oleg-jukovec
Copy link
Collaborator Author

oleg-jukovec commented Aug 7, 2023

thank you

Thank you for the issue, released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants