v2 begins #251
Merged
v2 begins #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/v2
branch
3 times, most recently
from
ca7e50e to
63161d5
Compare
Member
DifferentialOrange
left a comment
DifferentialOrange
left a comment
There was a problem hiding this comment.
Thank you for the PR! Seems mostly fine, have left a few comments.
oleg-jukovec
force-pushed
the
oleg-jukovec/v2
branch
from
8dc91dd to
c7d0a46
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/v2
branch
4 times, most recently
from
1fdb08e to
5bec533
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/v2
branch
2 times, most recently
from
941a7f3 to
36a9db0
Compare
oleg-jukovec
added a commit
to tarantool/go-iproto
that referenced
this pull request
Apr 20, 2023
Relates to tarantool/go-tarantool#251
oleg-jukovec
added a commit
to tarantool/go-iproto
that referenced
this pull request
Apr 20, 2023
Relates to tarantool/go-tarantool#251
oleg-jukovec
added a commit
to tarantool/go-iproto
that referenced
this pull request
Apr 24, 2023
Relates to tarantool/go-tarantool#251
oleg-jukovec
added a commit
to tarantool/go-iproto
that referenced
this pull request
Apr 24, 2023
Relates to tarantool/go-tarantool#251
oleg-jukovec
force-pushed
the
oleg-jukovec/v2
branch
2 times, most recently
from
15605d5 to
1db54fd
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/v2
branch
from
1db54fd to
e823260
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/v2
branch
from
e823260 to
55ed55f
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/v2
branch
from
55ed55f to
b2ea28d
Compare
DifferentialOrange
approved these changes
Apr 28, 2023
oleg-jukovec
force-pushed
the
oleg-jukovec/v2
branch
from
b2ea28d to
fecdd63
Compare
Member
|
Is there any non-cosmetic updates since last approval? |
Collaborator
Author
There is no changes. I just rebased the branch. |
better0fdead
approved these changes
May 24, 2023
oleg-jukovec
force-pushed
the
oleg-jukovec/v2
branch
from
fecdd63 to
ade4e6f
Compare
The package has been deprecated and we don't want to support it anymore. `pool` could be used instead of the package. Closes #240
By convention, packages are given lower case, single-word names; there should be no need for underscores or mixedCaps [1]. 1. https://go.dev/doc/effective_go#package-names Closes #239
Closes #235
Part of #158
Part of #158
IPROTO constants have been moved to a separate package go-iproto [1]. 1. https://github.com/tarantool/go-iproto Part of #158
oleg-jukovec
force-pushed
the
oleg-jukovec/v2
branch
from
ade4e6f to
176f1ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request starts work on
v2_WIPbranch. In the branch we will collect commits for the new major version of the connector will be beforev2publishing. See the publishing procedure:https://go.dev/doc/modules/major-version
The initial patches includes.
api: remove multi package
The package has been deprecated and we don't want to support it
anymore.
poolcould be used instead of the package.Closes #240
api: rename connection_pool to pool
By convention, packages are given lower case, single-word names; there
should be no need for underscores or mixedCaps [1].
Closes #239
api: msgpack.v5 by default
We found several critical bugs in the library msgpack.v2. It was
decided to update the libreary to msgpack/v5.
Closes #211
Closes #236
api: make Call = Call17
Closes #235
api: cleanup
Closes #158