Skip to content

utils: fix Tarantool version comparison #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DifferentialOrange
Copy link
Member

Before this patch, several features like uuid and fieldpaths support were not supported in Tarantool 3.0.0 because of invalid version comparison. This patch fixes the behavior, as well as introduces more convenient version parsing and comparison utils with new version policy support [1].

  1. https://www.tarantool.io/en/doc/latest/release/policy/

See https://github.com/tarantool/tarantool/actions/runs/4230129752/jobs/7347762364 as a fail example.

I didn't forget about

  • Tests
  • Changelog
  • Documentation (not needed)

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/tarantool-version-parsing-3.x branch 3 times, most recently from acbe0a8 to 07c919f Compare February 21, 2023 13:59
@DifferentialOrange DifferentialOrange changed the title fix: Tarantool version-dependent features for 3.x utils: fix Tarantool version comparison Feb 21, 2023
Before this patch, several features like uuid and fieldpaths support
were not supported in Tarantool 3.0.0 because of invalid version
comparison. This patch fixes the behavior, as well as introduces
more convenient version parsing and comparison utils with new version
policy support [1].

1. https://www.tarantool.io/en/doc/latest/release/policy/
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/tarantool-version-parsing-3.x branch from 07c919f to b04b50d Compare February 21, 2023 14:06
Copy link

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the patch.
LGTM.

@DifferentialOrange DifferentialOrange merged commit 09b0ce2 into master Feb 21, 2023
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/tarantool-version-parsing-3.x branch February 21, 2023 14:37
DifferentialOrange added a commit that referenced this pull request Mar 13, 2023
Overview

  This release introduces new API to check module version in code,
  as well as several compatibility bugfixes.

New features
  * Add versioning support (PR #342).

Bugfixes
  * Fix pre-hotreload `cartridge` support (older than 2.4.0) (PR #341).
  * Fix Tarantool version-dependent features for 3.x (PR #344).
DifferentialOrange added a commit that referenced this pull request Mar 13, 2023
Overview

  This release introduces new API to check module version in code,
  as well as several compatibility bugfixes.

New features
  * Add versioning support (PR #342).

Bugfixes
  * Fix pre-hotreload `cartridge` support (older than 2.4.0) (PR #341).
  * Fix Tarantool version-dependent features for 3.x (PR #344).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants