added support for default extensions #353
Open
+2,883
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resolves the file "contact.html" if the file "contact" does not exist
Author
|
I also added a test to validate default extensions are working. All tests are passing. |
Author
|
@tapio Any feedback? |
|
Hi @shanebdavis Looks nice. Feel free to add your PR to https://github.com/yandeu/five-server. |
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enabled the "extension" feature already present in the 'send' npm package to allow default extensions:
Example: "localhost:8080/contact" can now resolve the file "/contact.html" if the file "/contact" does not exist.