Commit 49 (Beta Candidate)

- Fix for BorisMoore#237 (Workaround for IE9 bug)
taoteg · Jan 17, 2014 · 521351a · 521351a
1 parent 7bad91d
commit 521351a
Show file tree

Hide file tree

Showing 10 changed files with 21 additions and 19 deletions.
diff --git a/jquery.observable.js b/jquery.observable.js
@@ -1,5 +1,5 @@
 /*! JsObservable v1.0.0-alpha: http://github.com/BorisMoore/jsviews and http://jsviews.com/jsviews
-informal pre V1.0 commit counter: 48 (Beta Candidate) */
+informal pre V1.0 commit counter: 49 (Beta Candidate) */
 /*
  * Subcomponent of JsViews
  * Data change events for data-linking
@@ -233,8 +233,9 @@ informal pre V1.0 commit counter: 48 (Beta Candidate) */
 		}
 
 		var i, p, skip, parts, prop, path, isArray, dep, unobserve, callback, cbId, el, data, events, contextCb, items, cbBindings, depth, innerCb, allPath, filter,
-			allowArray = this !== false, // If this === false, this is a call from observeAndBind - doing binding of datalink expressions. We don't bind
-			// arrayChange events in this scenario. Instead, {^{for}} and similar do specific arrayChange binding to the tagCtx.args[0] value, in onAfterLink
+			allowArray = this != false, // If this === false, this is a call from observeAndBind - doing binding of datalink expressions. We don't bind
+			// arrayChange events in this scenario. Instead, {^{for}} and similar do specific arrayChange binding to the tagCtx.args[0] value, in onAfterLink.
+			// Note deliberately using this != false, rather than this !== false because of IE<10 bug- see https://github.com/BorisMoore/jsviews/issues/237
 			topLevel = 1,
 			ns = observeStr,
 			paths = Array.apply(0, arguments),

diff --git a/jquery.observable.min.js b/jquery.observable.min.js
diff --git a/jquery.observable.min.js.map b/jquery.observable.min.js.map
diff --git a/jquery.views.js b/jquery.views.js
@@ -1,5 +1,5 @@
 /*! JsViews v1.0.0-alpha: http://github.com/BorisMoore/jsviews and http://jsviews.com/jsviews
-informal pre V1.0 commit counter: 48 (Beta Candidate) */
+informal pre V1.0 commit counter: 49 (Beta Candidate) */
 /*
  * Interactive data-driven views using templates and data-linking.
  * Requires jQuery and jsrender.js (next-generation jQuery Templates, optimized for pure string-based rendering)

diff --git a/jquery.views.min.js b/jquery.views.min.js
diff --git a/jsrender.js b/jsrender.js
@@ -1,5 +1,5 @@
 /*! JsRender v1.0.0-beta: http://github.com/BorisMoore/jsrender and http://jsviews.com/jsviews
-informal pre V1.0 commit counter: 48 */
+informal pre V1.0 commit counter: 49 */
 /*
  * Optimized version of jQuery Templates, for rendering to string.
  * Does not require jQuery, or HTML DOM