-
Notifications
You must be signed in to change notification settings - Fork 6
docs: event list panel #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @pigzhou, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the user documentation for data visualization features within TDengine IDMP. It introduces a new guide for the "Event List Panel" and provides a more detailed and user-friendly explanation of the "Asset List Panel," ensuring users have clear instructions for utilizing these powerful data display tools. Additionally, it includes minor updates to the general UI layout description and a restructuring of related documentation files. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation by adding sections for the event list panel and asset list panel, and refining the description of the breadcrumb bar. The changes are applied across both Chinese and English documentation, including restructuring some files. My review focuses on improving clarity and consistency by pointing out a few typos, inconsistent terminology, and a missing image in the English version.
i18n/en/docusaurus-plugin-content-docs/current/05-basic/01-layout.md
Outdated
Show resolved
Hide resolved
i18n/en/docusaurus-plugin-content-docs/current/05-basic/05-data-visualization/06-asset-list.md
Show resolved
Hide resolved
i18n/en/docusaurus-plugin-content-docs/current/05-basic/05-data-visualization/06-event-list.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds documentation for event list and breadcrumb bar panels to the documentation site, reorganizing the table visualization documentation structure.
Key Changes:
- Added event list panel documentation (English and Chinese versions)
- Reorganized asset list documentation from nested to top-level structure
- Added binary image asset for layout reference
Reviewed changes
Copilot reviewed 8 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
06-event-list.md (EN & CN) |
New documentation for event list panels with inconsistent button references |
06-asset-list.md (EN) |
Moved and reorganized asset list documentation from nested folder |
05-table/01-asset-list.md (EN) |
Removed old nested asset list documentation |
05-table.md (EN) |
Line number changes only, no content modifications |
assets/layout-01.png |
New binary image file added |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
i18n/en/docusaurus-plugin-content-docs/current/05-basic/05-data-visualization/06-event-list.md
Outdated
Show resolved
Hide resolved
i18n/en/docusaurus-plugin-content-docs/current/05-basic/05-data-visualization/06-event-list.md
Outdated
Show resolved
Hide resolved
wingwing2005
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Checklist
Please check the items in the checklist if applicable.